Skip to content

NumPy 1.12.0 has failing tests #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nils-werner opened this issue Jan 15, 2018 · 1 comment
Closed

NumPy 1.12.0 has failing tests #78

nils-werner opened this issue Jan 15, 2018 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue, pull request, or discussion
Milestone

Comments

@nils-werner
Copy link
Contributor

nils-werner commented Jan 15, 2018

Somewhere there is auto-densification happening, as I have many failing tests on my setup:

sparse/tests/test_core.py::test_elemwise[func0] FAILED
sparse/tests/test_core.py::test_elemwise[func1] FAILED
sparse/tests/test_core.py::test_elemwise[func2] FAILED
sparse/tests/test_core.py::test_elemwise[func3] FAILED
sparse/tests/test_core.py::test_elemwise[func4] FAILED
sparse/tests/test_core.py::test_elemwise[func5] FAILED
sparse/tests/test_core.py::test_elemwise[func6] FAILED
sparse/tests/test_core.py::test_elemwise[func7] FAILED
sparse/tests/test_core.py::test_elemwise[func8] FAILED
sparse/tests/test_core.py::test_elemwise[func9] FAILED
sparse/tests/test_core.py::test_elemwise[func10] PASSED
sparse/tests/test_core.py::test_elemwise[func11] FAILED
sparse/tests/test_core.py::test_elemwise[func12] PASSED
sparse/tests/test_core.py::test_elemwise[func13] FAILED
sparse/tests/test_core.py::test_elemwise[func14] FAILED
sparse/tests/test_core.py::test_elemwise[func15] PASSED
sparse/tests/test_core.py::test_elemwise[func16] PASSED

with

func = <ufunc 'floor'>

    @pytest.mark.parametrize('func', [np.expm1, np.log1p, np.sin, np.tan,
                                      np.sinh, np.tanh, np.floor, np.ceil,
                                      np.sqrt, np.conj, np.round, np.rint,
                                      lambda x: x.astype('int32'), np.conjugate,
                                      np.conj, lambda x: x.round(decimals=2), abs])
    def test_elemwise(func):
        s = sparse.random((2, 3, 4), density=0.5)
        x = s.todense()

        fs = func(s)

>       assert isinstance(fs, COO)
E       assert False
E        +  where False = isinstance(array([[[ 0.,  0.,  0.,  0.],\n        [ 0.,  0.,  0.,  0.],\n        [ 0.,  0.,  0.,  0.]],\n\n       [[ 0.,  0.,  0.,  0.],\n        [ 0.,  0.,  0.,  0.],\n        [ 0.,  0.,  0.,  0.]]]), COO)

Additionally, the two tests

sparse/tests/test_core.py::test_addition_not_ok_when_large_and_sparse
sparse/tests/test_core.py::test_raise_dense

basically never finish (I aborted them using Ctrl+C).

To reproduce this behaviour you can use the following tox.ini file

[tox]
envlist = {py27,py36}-{numpy12,numpylatest}
[testenv]
deps =
    numpy12: numpy==1.12.0
basepython =
    py27: python2.7
    py36: python3.6
commands=
    pip list
    py.test {posargs}
extras=
    docs
    tests

and run the specific tests using

tox -e py36-numpy12 -- -k test_elemwise
tox -e py36-numpy12 -- -k test_addition_not_ok_when_large_and_sparse
tox -e py36-numpy12 -- -k test_raise_dense
@hameerabbasi hameerabbasi added this to the 0.2 milestone Jan 16, 2018
@hameerabbasi hameerabbasi added the bug Indicates an unexpected problem or unintended behavior label Jan 16, 2018
@hameerabbasi hameerabbasi added the wontfix Indicates that work won't continue on an issue, pull request, or discussion label Jan 28, 2018
@hameerabbasi
Copy link
Collaborator

Numpy support is being dropped, see #84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior wontfix Indicates that work won't continue on an issue, pull request, or discussion
Projects
None yet
Development

No branches or pull requests

2 participants