Skip to content

Support mixed sparse-dense support when result is sparse #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2018

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Jan 12, 2018

Lots of changes here, but small ones.

  • Added a lot more operators, even if they fail consistently.
  • Added support for operators from both sides.
  • Moved a lot of functions out below the class.
  • (Most important) Where sparse/dense mixed operations are sparse (such as with operator.mul and operator.and_), support that with broadcasting and return a COO array.

@hameerabbasi hameerabbasi changed the title Mixed sparse dense Support mixed sparse-dense support when result is sparse Jan 12, 2018
@hameerabbasi
Copy link
Collaborator Author

This also supports cases like sparse / dense where (dense != 0).all() holds and sparse ** dense where (dense > 0).all() holds.

# Conflicts:
#	sparse/core.py
@hameerabbasi
Copy link
Collaborator Author

Merging at 18:00 German time if there are no further proposed changes.

@hameerabbasi hameerabbasi merged commit 6dca626 into pydata:master Jan 15, 2018
@hameerabbasi hameerabbasi deleted the mixed-sparse-dense branch January 15, 2018 17:29
hameerabbasi added a commit to hameerabbasi/sparse that referenced this pull request Feb 27, 2018
* Add left size arbitrary operator support + auto

* Extensive tests for operators and Numpy mixed broadcasting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant