Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas #10050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle partial coding
for more information, see https://pre-commit.ci
kmuehlbauer
commented
Feb 14, 2025
|
Thanks @kmuehlbauer—I'll try and take a look soon. It reminds me that maybe we should also resurrect #9498. |
There was a problem hiding this comment.
Thanks again @kmuehlbauer—tricky issues. I think I generally follow the changes—a couple questions to start out.
kmuehlbauer
changed the title
|
@spencerkclark Thanks for highlighting these issues. I think I've followed your hints and suggestions to improve here. |
spencerkclark
approved these changes
Mar 1, 2025
Co-authored-by: Spencer Clark <[email protected]>
…passing decode_times and decode_timedelta to CFMaskCoder and CFScaleOffsetCoder
3 tasks
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 19, 2025
* main: (67 commits) Refactor datetime and timedelta encoding for increased robustness (pydata#9498) Fix test_distributed::test_async (pydata#10138) Refactor concat / combine / merge into `xarray/structure` (pydata#10134) Split `apply_ufunc` out of `computation.py` (pydata#10133) Refactor modules from `core` into `xarray.computation` (pydata#10132) Refactor compatibility modules into xarray.compat package (pydata#10131) Fix type issues from pandas stubs (pydata#10128) Don't skip tests when on a `mypy` branch (pydata#10129) Change `python_files` in `pyproject.toml` to a list (pydata#10127) Better `uv` compatibility (pydata#10124) explicitly cast the dtype of `where`'s condition parameter to `bool` (pydata#10087) Use `to_numpy` in time decoding (pydata#10081) Pin pandas stubs (pydata#10119) Fix broken Zarr test (pydata#10109) Update asv badge url in README.md (pydata#10113) fix and supress some test warnings (pydata#10104) Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas (pydata#10050) Ensure KeyError raised for zarr datasets missing dim names (pydata#10025) Add typos check to pre-commit hooks (pydata#10040) Bump codecov/codecov-action from 5.3.1 to 5.4.0 in the actions group (pydata#10090) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstExpecially for datetime/timedelta decoding we are still running into issue when partly decoding or issues when trying to roundtrip partially decoded data. Another issue is with keeping track of state for packed data / masked data. This PR solves this by adding state to CFMaskCoder/CFScaleOffsetCoder.