Skip to content

Fix open_datatree when decode_cf=False #10141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Fix open_datatree when decode_cf=False #10141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abbffea
test: update render of simple_datatree
ianhi Mar 17, 2025
b5a538f
bugfix: correctly propagate decode_cf=False for datatrees
ianhi Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xarray/backends/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ def open_datatree(

decoders = _resolve_decoders_kwargs(
decode_cf,
open_backend_dataset_parameters=(),
open_backend_dataset_parameters=backend.open_dataset_parameters,
mask_and_scale=mask_and_scale,
decode_times=decode_times,
decode_timedelta=decode_timedelta,
Expand Down
42 changes: 21 additions & 21 deletions xarray/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,27 +164,27 @@ def create_test_datatree():
Create a test datatree with this structure:

<xarray.DataTree>
|-- set1
| |-- <xarray.Dataset>
| | Dimensions: ()
| | Data variables:
| | a int64 0
| | b int64 1
| |-- set1
| |-- set2
|-- set2
| |-- <xarray.Dataset>
| | Dimensions: (x: 2)
| | Data variables:
| | a (x) int64 2, 3
| | b (x) int64 0.1, 0.2
| |-- set1
|-- set3
|-- <xarray.Dataset>
| Dimensions: (x: 2, y: 3)
| Data variables:
| a (y) int64 6, 7, 8
| set0 (x) int64 9, 10
Group: /
│ Dimensions: (y: 3, x: 2)
│ Dimensions without coordinates: y, x
│ Data variables:
│ a (y) int64 24B 6 7 8
│ set0 (x) int64 16B 9 10
├── Group: /set1
│ │ Dimensions: ()
│ │ Data variables:
│ │ a int64 8B 0
│ │ b int64 8B 1
│ ├── Group: /set1/set1
│ └── Group: /set1/set2
├── Group: /set2
│ │ Dimensions: (x: 2)
│ │ Dimensions without coordinates: x
│ │ Data variables:
│ │ a (x) int64 16B 2 3
│ │ b (x) float64 16B 0.1 0.2
│ └── Group: /set2/set1
└── Group: /set3

The structure has deliberately repeated names of tags, variables, and
dimensions in order to better check for bugs caused by name conflicts.
Expand Down
18 changes: 18 additions & 0 deletions xarray/tests/test_backends_datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,24 @@ def test_to_netcdf(self, tmpdir, simple_datatree):
assert roundtrip_dt._close is not None
assert_equal(original_dt, roundtrip_dt)

def test_decode_cf(self, tmpdir):
filepath = tmpdir / "test-cf-convention.nc"
original_dt = xr.DataTree(
xr.Dataset(
{
"test": xr.DataArray(
data=np.array([0, 1, 2], dtype=np.uint16),
attrs={"_FillValue": 99},
),
}
)
)
original_dt.to_netcdf(filepath, engine=self.engine)
with open_datatree(
filepath, engine=self.engine, decode_cf=False
) as roundtrip_dt:
assert original_dt["test"].dtype == roundtrip_dt["test"].dtype

def test_to_netcdf_inherited_coords(self, tmpdir):
filepath = tmpdir / "test.nc"
original_dt = DataTree.from_dict(
Expand Down
Loading