Test for preserved dtype during datetime roundtrip #10159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah sorry after reading #9498 more thoroughly it appears this was intentional. I'll close this since it looks like we'll instead need to cast the dtypes in VirtualiZarr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of
_cast_to_dtype_if_safe()in https://github.com/pydata/xarray/pull/9498/files means that the dtype is not always preserved when roundtripping datetimes (xref zarr-developers/VirtualiZarr#492). This PR adds a test for that property. I'd be glad to add a fix in this PR as well, but first wanted to check if it was intentional to loosen the expectations around this property.whats-new.rstapi.rst