Skip to content

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 13, 2025

For ease of use, this implements a few additional methods on Coordinates:

  • rename_dims
  • rename_vars
  • drop_vars
  • drop_dims
  • coords1 | coords2 as an alias of coords1.merge(coords2)

These currently forward to the implementation in Dataset, but will be the natural place after refactoring Coordinates to not wrap a Dataset.


  • towards Coordinates operations #10314
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

cc @benbovy, @scottyhq

Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, those methods seem like a useful addition to me. Left a few minor comments.

@keewis
Copy link
Collaborator Author

keewis commented Jun 29, 2025

in 22c89e3 I fixed any complaints mypy had. However, this resulted in some less-than-ideal type hints, so I might need someone with more knowledge on typing to double-check.

@keewis keewis added the plan to merge Final call for comments label Jul 30, 2025
@keewis
Copy link
Collaborator Author

keewis commented Aug 23, 2025

given that this has been around for a while and nobody objected, I'll go ahead an merge once CI passes

@keewis keewis enabled auto-merge (squash) August 23, 2025 11:25
@keewis keewis merged commit 0074b76 into pydata:main Aug 23, 2025
36 checks passed
@keewis keewis deleted the coords-methods branch August 23, 2025 11:42
dcherian added a commit to dhruvak001/xarray that referenced this pull request Aug 24, 2025
* main: (46 commits)
  use the new syntax of ignoring bots (pydata#10668)
  modification methods on `Coordinates` (pydata#10318)
  Silence warnings from test_tutorial.py (pydata#10661)
  test: update write_empty test for zarr 3.1.2 (pydata#10665)
  Bump actions/checkout from 4 to 5 in the actions group (pydata#10652)
  Add load_datatree function (pydata#10649)
  Support compute=False from DataTree.to_netcdf (pydata#10625)
  Fix typos (pydata#10655)
  In case of misconfiguration of dataset.encoding `unlimited_dims` warn instead of raise (pydata#10648)
  fix ``auto_complex`` for ``open_datatree`` (pydata#10632)
  Fix bug indexing with boolean scalars (pydata#10635)
  Improve DataTree typing (pydata#10644)
  Update Cartopy and Iris references (pydata#10645)
  Empty release notes (pydata#10642)
  release notes for v2025.08.0 (pydata#10641)
  Fix `ds.merge` to prevent altering original object depending on join value (pydata#10596)
  Add asynchronous load method (pydata#10327)
  Add DataTree.prune() method              … (pydata#10598)
  Avoid refining parent dimensions in NetCDF files (pydata#10623)
  clarify lazy behaviour and eager loading chunks=None in open_*-functions (pydata#10627)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants