add assign_attrs method #1286
Merged
add assign_attrs method #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
approved these changes
Mar 5, 2017
xarray/core/common.py
Outdated
| @@ -346,6 +346,28 @@ def assign_coords(self, **kwargs): | |||
| data.coords.update(results) | |||
| return data | |||
|
|
|||
| def assign_attrs(self, *args, **kwargs): | |||
| """Assign new attrs to this object, returning a new object equivalent | |||
There was a problem hiding this comment.
Can you move the second half of this to a new line? We try to keep the title to one line.
There was a problem hiding this comment.
I'm sorry, I don't follow. I tried to match the conventions of the rest of the file. Do you mean this:
def assign_attrs(self, *args, **kwargs):
"""
Assign new attrs to this object, returning a new object equivalent
to...
or
def assign_attrs(self, *args, **kwargs):
"""Assign new attrs to this object.
Returns a new object equivalent to...
There was a problem hiding this comment.
The second version is preferred. But you're right that assign_coords also has a docstring that violates this.
There was a problem hiding this comment.
If you like, it would be awesome to clean that up, too.
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff(except for whatsnew... wasn't sure there)