Skip to content

Better error message for _FillValue vs missing_value conflicts #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2017
Merged

Better error message for _FillValue vs missing_value conflicts #1602

merged 2 commits into from
Oct 4, 2017

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 4, 2017

New behavior:

In [2]: ds = xarray.open_dataset('http://oos.soest.hawaii.edu/thredds/dodsC/hioos/tide_mhi', decode_cf=True)
...
ValueError: Conflicting _FillValue and missing_value attributes on a variable: -999.99 vs. -999.989990234

Consider opening the offending dataset using decode_cf=False, corrected the attributes and decoding explicitly using xarray.decode_cf().
  • Passes git diff upstream/master | flake8 --diff

I'm not writing new tests or a what's new notice for this.

@shoyer shoyer mentioned this pull request Oct 4, 2017
Closed
rabernat
rabernat reviewed Oct 4, 2017
View reviewed changes
xarray/conventions.py Outdated
raise ValueError("Conflicting _FillValue and missing_value "
"attributes on a variable: {} vs. {}\n\n"
"Consider opening the offending dataset "
"using decode_cf=False, corrected the "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected --> correcting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

@shoyer shoyer merged commit 41f4828 into pydata:master Oct 4, 2017
@shoyer shoyer deleted the better-fill-value-missing-value-conflicts branch October 4, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabernat rabernat rabernat left review comments

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoyer @rabernat @jhamman