Skip to content

Data vars in open mfdataset #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Oct 11, 2017
Merged

Data vars in open mfdataset #1623

merged 31 commits into from
Oct 11, 2017

Conversation

guziy
Copy link
Contributor

@guziy guziy commented Oct 11, 2017 •
edited
Loading

guziy added 30 commits September 19, 2017 12:17
@guziy
add data_vars option to open_mfdataset
180cf58
@guziy
use single quotes
6195fcd
@guziy
fix the 'line too long' warning from flake8
956fbeb
@guziy
document the data_vars keyword for open_mfdataset
e721620
@guziy
improve the data_vars record in whats-new
34b1004
@guziy
update my name in wats-new.rst
09d25c6
@guziy
Start writing the test for the data_vars keyword
e901a37
@guziy
use the data_vars keyword in combine
3141ce4
@guziy
address flake8 warnings for test_backend.py
8319aa7
@guziy
ignore flake8 warnings concerning whats-new.rst
fdc940e
@guziy
fix function reference in whats-new.rst
96e842e
@guziy
open_mfdataset does not accept dim keyword argument
b033bec
@guziy
use single quotes for strings in the added tests
b854ce4
@guziy
refactor data_vars related tests
787a98b
@guziy
Use with for opening mfdataset in data_vars related tests
4d3c685
@guziy
add @requires_scipy_or_netCDF4 to the data_vars test class
1823ba3
@guziy
address flake8 warnings about long lines in the data_vars related tests.
b47e665
@guziy
close opened datasets in case of a ValueError in open_mfdataset, seem…
23f0fc6 
…s important for Windows
@guziy
fix line too long warnings from flake8
05c8391
@guziy
refactor tests and open_mfdataset, to address comments
1f0e763
@guziy
refactor tests for data_vars keyword in open_mfdataset
fadda83
@guziy
refactor to address flake8 warnings
f80fe1f
@guziy
add another example of data_vars usage in open_mfdataset
14dee9d
@guziy
add coords keyword to open_mfdataset
f1f9d8b
@guziy
add a memory and performance related observations to the whats-new an…
f64c9e3 
…d modify code snippets to use single quotes for consistency.
@guziy
fixed a grammar mistake
633eec3
@guziy
quote variable names referenced in the text
086cf25
@guziy
add tests for coords keyword in the open_mfdataset, along with the si…
b0ca228 
…milar tests for the data_vars keyword.
@guziy
split a test into 2 to simplify, introduce context manager for settin…
e463e37 
…g up test inputs in OpenMFDatasetWithDataVarsAndCoordsKwTest
@guziy
make tests more explicit
70d8e2b
@shoyer
Copy link
Member

shoyer commented Oct 11, 2017

Can you try merging master into branch?

Alternatively, try making a new branch (from master) and cherry-picking your last commit.

@shoyer shoyer merged commit 2949558 into pydata:master Oct 11, 2017
@shoyer
Copy link
Member

shoyer commented Oct 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guziy @shoyer