Skip to content

Colorbar to FacetGrid plots #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

JoyMonteiro
Copy link

@JoyMonteiro JoyMonteiro commented Nov 22, 2017

  • Closes colorbars in facet grids #1717
  • Tests added / passed
  • Passes flake8
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@JoyMonteiro
Copy link
Author

Happy to make any changes required!!

@fmaussion
Copy link
Member

Thanks for the PR! It seems that your changes broke some tests. Could you have a look?

Also, it would be good to add a test for this feature. Here are the tests for facetgrids, and here is an example for the 2d plots cbar kwargs tests as a template.

Finally, if you have time it would be great to add an example in the docs ;). The easiest would be to add a cbar_kwargs kw to the call to facetgrid in this example. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants