Some backend tests require dask #1927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
requested changes
Feb 20, 2018
| @@ -1384,6 +1384,7 @@ def test_replace_slices_with_arrays(): | |||
|
|
|||
|
|
|||
| @requires_scipy | |||
| @requires_dask | |||
There was a problem hiding this comment.
This isn't quite right -- we still want to check the reading/writing a netCDF file with SciPy work without dask. I'm going to look alternate fixes for the can't pickle _thread.lock objects issue.
There was a problem hiding this comment.
OK! I'll leave this open for the moment
|
As #1923 & without really looking - I think this can be closed given that we test all but dask now: https://github.com/pydata/xarray/blob/master/ci/requirements/py38-all-but-dask.yml#L1 |
|
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMK if these are the right ones - I basically added the decorator to anything that was failing.
Though not sure we need to be 100% accurate here - worst case we could skip the file - either people are writing backend code and have dask installed, or they're not...