Resolve more warnings in the xarray test suite #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently down from 255 to 104 warnings.
|
Thanks. I have once tried to remove these warnings (mostly they are caused by my addition), but did not find a good way to do it. |
stickler-ci
reviewed
Mar 5, 2018
xarray/backends/rasterio_.py
Outdated
| @@ -2,6 +2,7 @@ | |||
| import warnings | |||
| from collections import OrderedDict | |||
| from distutils.version import LooseVersion | |||
| import warnings | |||
There was a problem hiding this comment.
F811 redefinition of unused 'warnings' from line 2
fmaussion
reviewed
Mar 5, 2018
doc/whats-new.rst
Outdated
| @@ -52,6 +52,8 @@ Bug fixes | |||
|
|
|||
| - Fix the precision drop after indexing datetime64 arrays (:issue:`1932`). | |||
| By `Keisuke Fujii <https://github.com/fujiisoup>`_. | |||
| - Silenced irrelevant warnings issued by ``open_rasterio`` (:issue:`1964`). | |||
There was a problem hiding this comment.
This isn't only rasterio warning anymore, is it?
There was a problem hiding this comment.
The other warnings only show up in our test suite, not to users. I'm not sure it's worth mentioning them.
fujiisoup
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been getting a little out of hand.
Currently down from 255 to 104 warnings.
xref #1652