Skip to content

Doc updates for 0.10.4 release #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2018
Merged

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 16, 2018

No description provided.

@shoyer shoyer mentioned this pull request May 16, 2018
@shoyer shoyer requested a review from jhamman May 16, 2018 18:34
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library. By `Spencer Clark
<https://github.com/spencerkclark>`_.
library.
By `Spencer Clark <https://github.com/spencerkclark>`_.
- Support writing lists of strings as netCDF attributes (:issue:`2044`).
By `Dan Nowacki <https://github.com/dnowacki-usgs>`_.
- :py:meth:`~xarray.Dataset.to_netcdf(engine='h5netcdf')` now accepts h5py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the :py:meth: declaration is working here, probably because engine is specified. We end up with: to_netcdf(engine='h5netcdf')() . Probably just drop the attempted link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

@shoyer shoyer merged commit 954b8d0 into pydata:master May 17, 2018
@shoyer shoyer deleted the 0.10.4-whats-new branch May 17, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants