Versioneer #2163
Merged
Versioneer #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
commented
May 18, 2018
| @@ -102,7 +102,7 @@ | |||
| # built documents. | |||
| # | |||
| # The short X.Y version. | |||
| version = xarray.version.short_version | |||
| version = xarray.__version__.split('+')[0] | |||
There was a problem hiding this comment.
this is the one change that worries me. It is possible people were relying on the xarray.version module...
There was a problem hiding this comment.
If they were... then they will have to fix up their code.
|
Versioneer has worked great for us. Cutting a release is triggered just by making a new release on GitHub. |
|
Very nice! I tested this out locally and it seems to properly with picking up new tags 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)This eliminates the need to edit
setup.pybefore / after release and is a nice step towards simplifying xarray's release process.