Skip to content

Plotting: restore xyincrease kwarg default to True #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

fmaussion
Copy link
Member

@fmaussion fmaussion commented Sep 20, 2018

#2294 introduced the new xincrease and yincrease kwargs and a behavior documented as:

    xincrease : None, True, or False, optional
        Should the values on the x axes be increasing from left to right?
        if None, use the default for the matplotlib function.

The default was None, I suggest to set it to True: it was the default before #2294 and I think it is what most users expect.

@fmaussion fmaussion requested a review from dcherian September 20, 2018 12:13
@dcherian
Copy link
Contributor

LGTM. Thanks!

@shoyer shoyer merged commit c1c576f into pydata:master Sep 21, 2018
@shoyer
Copy link
Member

shoyer commented Sep 21, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants