Skip to content

remove datetime tests with pint #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2020
Merged

remove datetime tests with pint #3788

merged 6 commits into from
Feb 28, 2020
+13 −8

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 21, 2020 •
edited
Loading

Since it does not make sense to try to wrap datetime objects in pint, I'm removing those tests. They still exposed a bug in the compatibility code of isnat: if dask is installed, the code would always use pd.isnull.

keewis
keewis commented Feb 21, 2020
View reviewed changes
@max-sixty
Copy link
Collaborator

LGTM!

dcherian
dcherian approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keewis keewis merged commit 20e6236 into pydata:master Feb 28, 2020
@keewis keewis deleted the remove-datetime-tests branch February 28, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two strange errors in tests TestVariable using .copy()
3 participants
@keewis @max-sixty @dcherian