Fix overflow-related bug in computing means of cftime.datetime arrays #4344
+38
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through
pandas.TimedeltaIndex
withinduck_array_ops._to_pytimedelta
leads to overflow problems (presumably it casts to a"timedelta64[ns]"
type internally). This PR updates the logic to directly use NumPy to do the casting, first to"timedelta64[us]"
, then todatetime.timedelta
.isort . && black . && mypy . && flake8
whats-new.rst