Skip to content

Silencing numpy warnings #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 2, 2020
Merged

Silencing numpy warnings #4369

merged 17 commits into from
Sep 2, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Aug 22, 2020 •
edited by keewis
Loading

  • Closes Don't warn on empty reductions #3811
  • Tests added
  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Is this the right approach? Or should we be using np.errstate machinery?

@mathause
Copy link
Collaborator

I think this thread suggests to use warning: numpy/numpy#10709

@max-sixty max-sixty marked this pull request as ready for review August 30, 2020 02:18
max-sixty
max-sixty commented Aug 30, 2020
View reviewed changes
keewis
keewis approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the linter-enforced else clause seems a bit strange to me

@max-sixty max-sixty merged commit 8950993 into pydata:master Sep 2, 2020
@max-sixty max-sixty deleted the numpy-warning branch September 2, 2020 22:26
@max-sixty
Copy link
Collaborator Author

LGTM, but the linter-enforced else clause seems a bit strange to me

Yeah, I think it makes sense the context of the function alone — it doesn't know that the values are limited to the two parameterizations. Though this fix trades one error for another, in the end.

@keewis keewis mentioned this pull request Feb 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't warn on empty reductions
3 participants
@max-sixty @mathause @keewis