remove all inplace parameters from the public API #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Do we want to wait for 0.17 though? |
|
should we merge this now that |
|
Yes I think that makes sense — the next can be 0.17.0. There's some value to not leaving these unmerged given future conflicts. |
|
Works for me |
|
Should we add the breaking change to whatsnew? |
|
I'm not sure we should call this a breaking change, the Edit: I can still add a entry to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #4561 this has been around for about 3 major versions. Not sure if it's too soon to remove it altogether, but I guess if we decide it is we can just wait with the merge until it is not.
isort . && black . && mypy . && flake8