Skip to content

use assert_allcose on test_resample_loffset #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

sebix
Copy link
Contributor

@sebix sebix commented May 23, 2021

test_resample_loffset failed on i586 with Python 3.9 as it used
assert_identical.
Changed to the more permissive assert_allclose.

test_resample_loffset failed on i586 with Python 3.9 as it used
assert_identical.
Changed to the more permissive assert_allclose.

fixes pydata#5341
@max-sixty
Copy link
Collaborator

Thanks @sebix

Do we know where the difference is coming from? If I'm reading the test correctly, the floats aren't related to the offset — which is on discrete values — and so this may be a broader problem. Is that right?

@sebix
Copy link
Contributor Author

sebix commented May 23, 2021

Thanks @sebix

Do we know where the difference is coming from? If I'm reading the test correctly, the floats aren't related to the offset — which is on discrete values — and so this may be a broader problem. Is that right?

Sorry, I have no more insight, I just know that the test is failing on that particular architecture (x86_64, ppc64, ppc64le, aarch64 are fine).

@max-sixty
Copy link
Collaborator

Does anyone have a better idea than I do (very little) on this?

@max-sixty
Copy link
Collaborator

I missed that @dcherian had suggested this. Merged. Many thanks @sebix .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test test_resample_loffset fails on i586 with Python 3.9
2 participants