Fix invalid suggestion in error in apply_variable_ufunc #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated errors, see #5366. |
max-sixty
reviewed
Jun 6, 2021
| @@ -678,7 +678,7 @@ def apply_variable_ufunc( | |||
| "apply_ufunc with dask='parallelized' consists of " | |||
| "multiple chunks, but is also a core dimension. To " | |||
| "fix, either rechunk into a single dask array chunk along " | |||
| f"this dimension, i.e., ``.chunk({dim}: -1)``, or " | |||
| f"this dimension, i.e., ``.chunk(dict({dim}=-1))``, or " | |||
There was a problem hiding this comment.
Suggested change
| f"this dimension, i.e., ``.chunk(dict({dim}=-1))``, or " | |
| f"this dimension, i.e., ``.chunk(dict(dim=-1))``, or " |
There was a problem hiding this comment.
But then it's not copy/paste friendly?
I got this error a few times in the cross product pr and I felt it was a nice and helpful idea to just be able to append .chunk(dict(cartesian=-1)) without having to think.
There was a problem hiding this comment.
Sorry! I misread this. Your idea is great
There was a problem hiding this comment.
note that this is not copy-paste friendly in general: dict(1=-1) is invalid python
|
Thanks @Illviljan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestion appears to be copy/paste-friendly but the format was slightly off.