-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Implement weighted groupby #5480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f6c41ae
to
820cab9
Compare
820cab9
to
f2de991
Compare
return combined | ||
|
||
|
||
class DatasetGroupBy(DatasetGroupByCombine, DatasetGroupbyArithmetic): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled out combine because the inheritance order is DatasetGroupBy → DatasetGroupByArithmetic → ImplementsDatasetReduce → IncludeReduceMethods . That last one overwrites the reductions on WeighedGroupBy
if it inherits from DatasetGroupBy
This attempt subclasses GroupBy and works as @shoyer let me know what you think |
pre-commit run --all-files
whats-new.rst
api.rst
Initial proof-of-concept. Suggestions to improve this are very welcome.
Here's some convenient testing code
I've added info to the repr