Skip to content

Make the sel error more descriptive when method is unset #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Make the sel error more descriptive when method is unset #6774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e03ae4a
Make the sel error more descriptive when `method` is unset
jsignell Jul 11, 2022
bd85797
Apply suggestions from code review
jsignell Jul 12, 2022
ecc3683
Merge branch 'main' into sel-error-message
jsignell Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion xarray/core/indexes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,14 @@ def sel(
f"not all values found in index {coord_name!r}"
)
else:
indexer = self.index.get_loc(label_value)
try:
indexer = self.index.get_loc(label_value)
except KeyError as e:
raise KeyError(
f"not all values found in index {coord_name!r}. "
"Did you mean to set `method=`?"
) from e

elif label_array.dtype.kind == "b":
indexer = label_array
else:
Expand Down
3 changes: 3 additions & 0 deletions xarray/tests/test_dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,9 @@ def test_sel_no_index(self) -> None:
def test_sel_method(self) -> None:
data = DataArray(np.random.randn(3, 4), [("x", [0, 1, 2]), ("y", list("abcd"))])

with pytest.raises(KeyError, match="Did you mean to set `method=`?"):
data.sel(y="ab")

expected = data.sel(y=["a", "b"])
actual = data.sel(y=["ab", "ba"], method="pad")
assert_identical(expected, actual)
Expand Down