Fix step plots with hue #6944
Merged
Fix step plots with hue #6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - but from staring at the code it seems to me the logic is the same as before? |
|
It may appear so but it's not: |
mathause
approved these changes
Aug 25, 2022
andersy005
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Looks solid to me 👍🏽. @mgunyho, thank you for this addition, and welcome to the Xarray community 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broadcasting error when trying to plot multiple step plots, like
arr.plot.step(..., hue=...)orarr.plot(..., drawstyle="steps-mid"). Previously, this raised a shape error, as mentioned in #4288 (comment). Some other relevant work was started (but apparently unfinished) in #4868 and #4866, this doesn't implement those.whats-new.rst