Preserve all attrs with GroupBy by default. #7022
Conversation
Closes pydata#7012 When `use_flox=False`, we pass `keep_attrs=None` to `Data*.reduce`. This ends up delete Dataset and DataArray level attrs but preserves coordinate variable attrs. We now set the default to True always to match the default behaviour of `apply_ufunc` used by `flox.xarray.xarray_reduce`.
| @@ -65,6 +65,9 @@ Bug fixes | |||
| By `András Gunyhó <https://github.com/mgunyho>`_. | |||
| - Avoid use of random numbers in `test_weighted.test_weighted_operations_nonequal_coords` (:issue:`6504`, :pull:`6961`). | |||
| By `Luke Conibear <https://github.com/lukeconibear>`_. | |||
| - Use ``keep_attrs=True`` in grouping and resampling operations by default (:issue:`7012`). | |||
There was a problem hiding this comment.
I think they were kept without flox - do you want to mention this?
There was a problem hiding this comment.
Dataset level attrs were lost earlier:
Line 5603 in b018442
Now its always preserved whether you use flox or not. Should I clarify the second line here more.
There was a problem hiding this comment.
Should I clarify the second line here more.
Thanks for the clarification - fine to leave as is for me.
| @@ -30,7 +30,7 @@ def dataset(): | |||
| "foo": (("x", "y", "z"), np.random.randn(3, 4, 2)), | |||
| "baz": ("x", ["e", "f", "g"]), | |||
| }, | |||
| {"x": ["a", "b", "c"], "y": [1, 2, 3, 4], "z": [1, 2]}, | |||
| {"x": ("x", ["a", "b", "c"], {"name": "x"}), "y": [1, 2, 3, 4], "z": [1, 2]}, | |||
There was a problem hiding this comment.
I assume there is a assert_identical somewhere below?
There was a problem hiding this comment.
Yes some existing tests failed when I added this.
| @@ -65,6 +65,9 @@ Bug fixes | |||
| By `András Gunyhó <https://github.com/mgunyho>`_. | |||
| - Avoid use of random numbers in `test_weighted.test_weighted_operations_nonequal_coords` (:issue:`6504`, :pull:`6961`). | |||
| By `Luke Conibear <https://github.com/lukeconibear>`_. | |||
| - Use ``keep_attrs=True`` in grouping and resampling operations by default (:issue:`7012`). | |||
There was a problem hiding this comment.
Should I clarify the second line here more.
Thanks for the clarification - fine to leave as is for me.
Closes #7012
When
use_flox=False, we passkeep_attrs=NonetoData*.reduce. This ends up delete Dataset and DataArray level attrs but preserves coordinate variable attrs. We now set the default to True always to match the default behaviour ofapply_ufuncused byflox.xarray.xarray_reduce.whats-new.rst