Skip to content

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Sep 25, 2022

@headtr1ck headtr1ck added the plan to merge Final call for comments label Sep 25, 2022
@DWesl
Copy link
Contributor

DWesl commented Sep 27, 2022

I think the current default for two-dimensional plots is to try to re-use an existing axis if neither row nor col are set (implied by documentation for ax argument in the description of the DataArray.plot descriptor). Would this PR change that behavior, and should that be documented?

@headtr1ck
Copy link
Collaborator Author

I think the current default for two-dimensional plots is to try to re-use an existing axis if neither row nor col are set (implied by documentation for ax argument in the description of the DataArray.plot descriptor). Would this PR change that behavior, and should that be documented?

If you do not specify size, figsize, aspect, row, col or ax, it should still use the current axis.
But you are right, that deserves a test :)

@headtr1ck
Copy link
Collaborator Author

And additionaly, we should change the description. The one of DataArray.plot.line is better.
I will change this.

Thanks for noticing!

@dcherian dcherian merged commit e2c29f6 into pydata:main Sep 28, 2022
@headtr1ck headtr1ck deleted the getaxes branch September 28, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot set figsize when plotting map with cartopy
4 participants