Skip to content

Fix mypy 0.990 types #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix mypy 0.990 types #7283

merged 1 commit into from
Nov 16, 2022

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck
Copy link
Collaborator Author

Alternatively we could also set no_implicit_optional=False, but I like the explicit types.

@headtr1ck headtr1ck added the plan to merge Final call for comments label Nov 15, 2022
@dcherian dcherian merged commit c86ffea into pydata:main Nov 16, 2022
@max-sixty
Copy link
Collaborator

Thanks @headtr1ck !

@headtr1ck headtr1ck deleted the mypy990 branch November 18, 2022 15:42
@keewis keewis mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plan to merge Final call for comments topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headtr1ck @max-sixty @dcherian