Skip to content

User guide zarr file missing values note #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinspetlik
Copy link

Copy link

welcome bot commented Feb 14, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@@ -898,6 +898,7 @@ where the data should be written (in index space, not label space), e.g.,

Concurrent writes with ``region`` are safe as long as they modify distinct
chunks in the underlying Zarr arrays (or use an appropriate ``lock``).
Note that incorrectly (or omitting) setting the ``chunksizes`` for the initial Zarr file results in a partial update of the chunks when writing to regions, causing missing values in the Zarr file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about writing to regions to comment on the content, so here are some style suggestions:

Suggested change
Note that incorrectly (or omitting) setting the ``chunksizes`` for the initial Zarr file results in a partial update of the chunks when writing to regions, causing missing values in the Zarr file.
Note that incorrectly setting (or omitting) the ``chunksizes`` for the initial
Zarr file results in a partial update of the chunks when writing to regions,
causing missing values in the Zarr file.

We could also use .. note:: for this if we think this is important enough.

@max-sixty
Copy link
Collaborator

Good to have this in the docs given we haven't fixed the issue.

But I think we should phrase this as a bug and link to the issue, since it's not desired behavior...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling to_zarr inside map_blocks function results in missing values
3 participants