Skip to content

Conversation

chaosue
Copy link

@chaosue chaosue commented Feb 26, 2024

图片

as shown above, after stopping the master cells process, there might be some sub processes left defunct in random.
two points in cells may lead to this problem.

  1. The Stop method in main routine does not wait the StartAndWait method to complete waiting its sub process.
  2. The gateway.data plugin , which uses the minio package, does not fork, so it still serves in the main process, while the minio's exit function will directly end the main process when stopping the pulgin. However the minio's exit function cannot be customized, so there's no way to tweak this behaviour from the minio side at present. Only the forking way may resolve it.

so whether there will be defunct processes depends on who (the main process and its sub processes) exits first in random.

another point, shall we deregister the server to notify the client-ends in advance before stopping the server to prevent unexpected future requests.

@cdujeu
Copy link
Member

cdujeu commented Mar 25, 2024

needs more attention, we will dig that one, seems to have side-effect (require multiple Ctrl+C sometimes).
Also @chaosue for the next ones, make sure to not mess up the imports : we always group them in three blocks: standard lib, third party libs, cells modules.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chaos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants