Add hook for eel to collect eel.js and an import #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legorooj
approved these changes
Jun 20, 2020
Legorooj
pushed a commit
that referenced
this pull request
Jun 21, 2020
samuelhwilliams
added a commit
to python-eel/Eel
that referenced
this pull request
Jun 21, 2020
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
samuelhwilliams
added a commit
to python-eel/Eel
that referenced
this pull request
Feb 6, 2023
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
samuelhwilliams
added a commit
to python-eel/Eel
that referenced
this pull request
Feb 6, 2023
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
samuelhwilliams
added a commit
to python-eel/Eel
that referenced
this pull request
Feb 6, 2023
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
samuelhwilliams
added a commit
to python-eel/Eel
that referenced
this pull request
Feb 6, 2023
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I hope this is the correct place to put up a contribution and the right way to do it.
I'm maintaining a project called Eel which currently has a custom build script to help pull in the correct files. It would be nice if that was less necessary by having a pyinstaller hook for it.
Please let me know if anything more is needed.