Skip to content

Refactor and remove redefined-variable-type disable #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Seems easy enough to fix this and allow this check to be enabled. Would be necessary for mypy (at some point) anyway.

Type of Changes

Type
🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Oct 24, 2021
@DanielNoord DanielNoord added this to the 2.8.4 milestone Oct 24, 2021
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a surprisingly small refactor. I guess working on mypy already removed a lot of issues we were having. Great removal !

@DanielNoord DanielNoord merged commit 1620fb3 into pylint-dev:main Oct 24, 2021
@DanielNoord DanielNoord deleted the redefined branch October 24, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants