-
-
Notifications
You must be signed in to change notification settings - Fork 293
Restore custom distutils
handling for resolving paths to submodules.
#1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
08b30a0
Restore custom `distutils` handling for resolving paths to submodules.
jacobtylerwalls 5fa8fbf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 301f350
no reimport
jacobtylerwalls 8d6e0f6
Improve CI step
jacobtylerwalls 14d2e12
Fix cache identifiers
jacobtylerwalls 789f606
python -m pylint
jacobtylerwalls 9e374fa
Activate virtualenv
jacobtylerwalls 3a601fa
setup python
jacobtylerwalls de390f5
better cache key
jacobtylerwalls ed6c8f1
Update .github/workflows/ci.yaml
jacobtylerwalls d95fe1a
Revert "Update .github/workflows/ci.yaml"
jacobtylerwalls 7abdd57
Move virtualenv 15.0 test to "release test" workflow
jacobtylerwalls b0134dc
add comment re: github actions
jacobtylerwalls 17388bd
Further comments
jacobtylerwalls 09345aa
Last changes
cdce8p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: Release tests | ||
|
||
on: workflow_dispatch | ||
|
||
env: | ||
DEFAULT_PYTHON: 3.8 | ||
|
||
jobs: | ||
virtualenv-15-windows-test: | ||
# Regression test added in https://github.com/PyCQA/astroid/pull/1386 | ||
name: Regression test for virtualenv==15.1.0 on Windows | ||
runs-on: windows-latest | ||
timeout-minutes: 5 | ||
steps: | ||
- name: Check out code from GitHub | ||
uses: actions/[email protected] | ||
- name: Set up Python | ||
id: python | ||
uses: actions/[email protected] | ||
with: | ||
python-version: ${{ env.DEFAULT_PYTHON }} | ||
- name: Create Python virtual environment with virtualenv==15.1.0 | ||
run: | | ||
python -m pip install virtualenv==15.1.0 | ||
python -m virtualenv venv2 | ||
. venv2\scripts\activate | ||
python -m pip install pylint | ||
python -m pip install -e . | ||
- name: Test no import-error from distutils.util | ||
run: | | ||
. venv2\scripts\activate | ||
echo "import distutils.util # pylint: disable=unused-import" > test.py | ||
pylint test.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.