Skip to content

Add Try node #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add Try node #1389

wants to merge 2 commits into from

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 10, 2022

Description

Depends on #1388

In the Python AST TryExcept and TryFinally have long been replaced by Try. This PR adds a new Try node to do the same in astroid.

To test this change in pylint, add this in pylinter.py (after the imports).

from astroid.manager import AstroidManager
AstroidManager.tree_rev = 2

Type of Changes

Type
✨ New feature

@cdce8p cdce8p added High effort 🏋 Difficult solution or problem to solve Work in progress labels Mar 7, 2022
@cdce8p cdce8p force-pushed the tree_try-node branch 2 times, most recently from 1da8c9b to b4b68af Compare March 7, 2022 01:02
@cdce8p cdce8p mentioned this pull request Apr 22, 2022
5 tasks
@coveralls
Copy link

coveralls commented May 13, 2022

Pull Request Test Coverage Report for Build 3403718144

  • 64 of 73 (87.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/rebuilder.py 14 18 77.78%
astroid/nodes/node_classes.py 50 55 90.91%
Files with Coverage Reduction New Missed Lines %
astroid/rebuilder.py 1 96.31%
Totals Coverage Status
Change from base Build 3393053917: -0.04%
Covered Lines: 9922
Relevant Lines: 10757

💛 - Coveralls

@cdce8p cdce8p mentioned this pull request Nov 14, 2022
@cdce8p
Copy link
Member Author

cdce8p commented Nov 14, 2022

Superseded by #1867

@cdce8p cdce8p closed this Nov 14, 2022
@cdce8p cdce8p deleted the tree_try-node branch November 14, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High effort 🏋 Difficult solution or problem to solve Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants