Skip to content

Update FormattedValue.postinit and its brain #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Feb 12, 2023

Type of Changes

Type
🐛 Bug fix

Description

Refs #1516.

Decided to make this a breaking change as it just so much easier to update signatures when these are keyword only. I don't think a small breaking change at the top of the signature matters too much.

Using an Enum doesn't make a lot of sense as the ast module has it as an int. So we would need to of some casting to that Enum and that could be the source of nasty crashes,

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #2029 (be2d39e) into main (d57e34f) will increase coverage by 0.00%.
The diff coverage is 81.81%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2029   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          95       95           
  Lines       11000    11003    +3     
=======================================
+ Hits        10206    10209    +3     
  Misses        794      794           
Flag Coverage Δ
linux 92.54% <81.81%> (+<0.01%) ⬆️
pypy 88.50% <81.81%> (+<0.01%) ⬆️
windows 92.33% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/rebuilder.py 98.29% <ø> (ø)
astroid/brain/brain_fstrings.py 36.66% <77.77%> (+7.03%) ⬆️
astroid/nodes/node_classes.py 94.87% <100.00%> (ø)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably cover what's not currently covered ?

@DanielNoord
Copy link
Collaborator Author

Shall we do that in a follow up? Functionally nothing changes here, other than conversion now being passed correctly in the brain were it was previously just dropped. This whole brain seems to be untested and I don't want to block this PR on me having time to look at the testing of the brain.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2108ae5 into pylint-dev:main Feb 13, 2023
@DanielNoord DanielNoord deleted the formatted-value branch February 13, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants