Update FormattedValue.postinit
and its brain
#2029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs #1516.
Decided to make this a breaking change as it just so much easier to update signatures when these are keyword only. I don't think a small breaking change at the top of the signature matters too much.
Using an
Enum
doesn't make a lot of sense as theast
module has it as anint
. So we would need to of some casting to thatEnum
and that could be the source of nasty crashes,