Remove @cached decorator and CACHE_MANAGER

[jacobtylerwalls]

Type of Changes

	Type
✓	🔨 Refactoring

Description

See discussion in #1780, much of the remaining leaking was due to having an inferior version of the stdlib's @cached_property. There's no reason to maintain a poorer version ourselves.

Closes #1780

Benchmark

From the script linked here, I now see:

python3 memory.py

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)


Nodes INC: 103014
Nodes NEW: 103014
Dicts INC: 55562
Dicts NEW: 55562

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)


Nodes INC: 0
Nodes NEW: 103014
Dicts INC: 27
Dicts NEW: 55589

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)


Nodes INC: 0
Nodes NEW: 103014
Dicts INC: 15
Dicts NEW: 55604

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)


Nodes INC: 0
Nodes NEW: 103014
Dicts INC: 15
Dicts NEW: 55619

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)


Nodes INC: 0
Nodes NEW: 103014
Dicts INC: 15
Dicts NEW: 55634

While "Dicts INC" isn't perfect (isn't 0), I think we've finished all the work we've identified so far, and I'm okay closing the linked issue.

[codecov]

Codecov Report

Merging #2072 (220d78c) into main (6714f15) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
- Coverage   92.82%   92.78%   -0.05%     
==========================================
  Files          95       94       -1     
  Lines       11066    11043      -23     
==========================================
- Hits        10272    10246      -26     
- Misses        794      797       +3     

Flag	Coverage Δ
linux	92.54% <100.00%> (-0.05%)	⬇️
pypy	88.09% <100.00%> (-0.09%)	⬇️
windows	92.33% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
astroid/manager.py	88.10% <ø> (-0.11%)	⬇️
astroid/bases.py	88.50% <100.00%> (-0.04%)	⬇️
astroid/decorators.py	84.07% <100.00%> (-1.42%)	⬇️
astroid/nodes/scoped_nodes/scoped_nodes.py	93.07% <100.00%> (+0.01%)	⬆️

... and 1 file with indirect coverage changes

[Pierre-Sassoulas]

Amazing !

[Pierre-Sassoulas]

I'm wondering if this should go in 2.15.2

[jacobtylerwalls]

I removed @cached without a deprecation warning. It will cause a few breakages in pylint. I know we're becoming more pragmatic about backwards compatibility in astroid, but if we're keeping to semantic versioning, let's not do it in a patch release. WDYT?

[Pierre-Sassoulas]

Ha ok, we're using it elsewhere too. I thought it was only used in astroid and replaced by a proper cache on the fly. Make sense !