Skip to content

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Add attr.Factory to the recognized class attributes for classes decorated with attrs.

Closes pylint-dev/pylint#4341

@mbyrnepr2 mbyrnepr2 added this to the 2.16.0 milestone Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2126 (e341b0c) into main (ae9ce82) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          94       94           
  Lines       11007    11007           
=======================================
  Hits        10207    10207           
  Misses        800      800           
Flag Coverage Δ
linux 92.45% <ø> (ø)
pypy 87.88% <ø> (ø)
windows 92.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/brain/brain_attrs.py 100.00% <ø> (ø)

@DanielNoord DanielNoord merged commit 29407df into pylint-dev:main Apr 19, 2023
@mbyrnepr2 mbyrnepr2 deleted the pylint_4341_attr_false_positive branch April 19, 2023 21:16
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.16.0, 3.0 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attrs: wrong type inferred from Factory attribute (using auto_attribs)
3 participants