Skip to content

handle case of "attr" decorators with arguments #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2018
Merged

handle case of "attr" decorators with arguments #479

merged 1 commit into from
Jan 18, 2018

Conversation

zadamah
Copy link

@zadamah zadamah commented Jan 17, 2018

Fixes / new features

Copy link
Contributor

@rogalski rogalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) .

@PCManticore lack of coverage check for PRs is intentional?

@zadamah
Copy link
Author

zadamah commented Jan 17, 2018

thanks for the review Łukasz :)

@PCManticore PCManticore merged commit d768d7f into pylint-dev:master Jan 18, 2018
@PCManticore
Copy link
Contributor

Thank you @zadamah
@rogalski Nope, I'm not sure what happens with coveralls. It is enabled and it is configured to use the status API for PRs. Going to take a closer look in the weekend.

@zadamah zadamah deleted the pull-request-attr-transform branch January 18, 2018 10:39
@joshburkart
Copy link

Thank you for doing this!!

@zadamah
Copy link
Author

zadamah commented Apr 23, 2018

Happy to hear that it is useful to you too 😃
I Hope it'll be in the next pylint release (if it's not already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants