Demonstrate a problem with attrs w/ annotations #750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @webknjaz Thanks for the PR. I'm not entirely sure what's the problem exactly? Can you open an issue instead? |
|
Yes sure. Looks like it's the issue already exists: #724. |
|
I mentioned later in the original issue, but this is foremost a deficiency of type-annotated attributes on plain classes (not using attrs library). I gave example code there (" |
|
Oh, so almost the same but not quite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR extends attrs tests in order to demonstrate a not-yet-covered case described in #724.
Type of Changes
Related Issue
N/A