Squash one-use inference utility functions to reduce recursion errors #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycepg
changed the title
brycepg
force-pushed
the
issue/squash-stack-use
branch
3 times, most recently
from
b745c31 to
0655d0a
Compare
…rrors This also makes debugging a lot simpler reducing the complexity of the function stack.
brycepg
force-pushed
the
issue/squash-stack-use
branch
from
0655d0a to
b39deef
Compare
|
Nice! |
brycepg
added a commit
to brycepg/astroid
that referenced
this pull request
Jun 24, 2020
…rrors (pylint-dev#804) This also makes debugging a lot simpler reducing the complexity of the function stack.
brycepg
added a commit
to brycepg/astroid
that referenced
this pull request
Jun 24, 2020
…rrors (pylint-dev#804) This also makes debugging a lot simpler reducing the complexity of the function stack.
brycepg
added a commit
that referenced
this pull request
Jun 24, 2020
…rrors (#804) This also makes debugging a lot simpler reducing the complexity of the function stack.
|
When can a release that incorporates this fix be expected? |
3 tasks
6 tasks
|
Releasing this in pypi is critical for pylint to work "out of the box" in several python projects |
|
Has this been released to PyPI? I can only see the release form June 8th. |
|
@jonlundy It hasn't, to the best of my knowledge. I still install this from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Squash single-use inference utility functions to reduce recursion errors by squashing generators together. This change stops recursion errors from occuring for some complex code.
This also makes debugging a lot simpler by reducing the complexity of the function stack.
I've been unable to create a regression test due to the nature of this issue however I have manually tested that this change fixes the below mentioned issues.
Type of Changes
Related Issue
Fixes pylint-dev/pylint#2843
Fixes pylint-dev/pylint#2811
Changes pylint-dev/pylint#3602 error into a MemoryError for me (which makes the underlying issue more apparent I suppose)