-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Performance degradation between version 2.7.2 and 2.7.4? #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for opening the issue. Do you use generic classes ? (#4079) |
Yes, I do. But as I mentioned, performance was okay 20 days ago, while issue #4079 is a little older. |
I made some test and, at least for Python 3.6, there seems to be an issue with astroid. As mentioned above, with this combination of packages Pylint runs (almost) forever:
For this combination, its the same:
However, going back to astroid 2.5.1 restores the original performance:
I am almost sure the problem arises when Pylints analyses a chain of generic classes in my codebase. Possibly due to "Fix mro for classes that inherit from typing.Generic*" of astroid 2.5.3? |
@tyralla thanks for your report and investigation! |
…en pylint issue pylint-dev/pylint#4353 is fixed).
@tyralla are you facing the same problem with latest versions of |
@hippo91: Sorry for the late response. Pylint now finishes within a reasonable time limit again on my local computer (Pylint 2.9.5, Astroid 2.6.5, Python 3.8.5, Windows). Unfortunately, I cannot check it on Travis-CI (Python 3.6) anymore - no more free open source support. Thank you very much for your effort! |
I know there other issues dealing with the performance of Pylint 2.7.0 and generics, but this problem seems a little different to me.
20 days ago, Pylint evaluated my project (which uses generics) on Travis-CI in the usual amount of time (806 seconds). This is what Travis installed then:
Now, Pylint cannot finish within any reasonable time limit. This is from the latest log file:
On my local computer, both version 2.7.2 and 2.7.4 and also some older versions I tried are way too slow (I manually stopped the process after more than an hour; I cannot remember this happened ever before). Note that Travis-CI uses Python 3.6, and I use Python 3.8 on my local computer.
The text was updated successfully, but these errors were encountered: