Skip to content

pylint.rc file parsing #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvdv opened this issue Mar 1, 2016 · 4 comments
Closed

pylint.rc file parsing #828

nvdv opened this issue Mar 1, 2016 · 4 comments

Comments

@nvdv
Copy link

nvdv commented Mar 1, 2016

I am not sure if it's serious enough, but in this case duplicate code check is not disabled (Python 2, Python 3 works fine):

[MESSAGES CONTROL]
disable=locally-disabled, no-self-use, exec-used, too-few-public-methods,
        too-many-instance-attributes, bad-builtin, wrong-import-order,
        superfluous-parens, import-error, fixme, duplicate-code
        # Disable duplicate-code globally

In this case it is disabled:

        ...
        superfluous-parens, import-error, fixme, duplicate-code,
        # Disable duplicate-code globally
        ...

Notice extra comma after duplicate-code.

@PCManticore
Copy link
Contributor

I'm not sure I understand, we have no comma after duplicate-code in our pylint.rc file or it's just that we don't parse files with no comma after the last element followed by a comment?

@nvdv
Copy link
Author

nvdv commented Mar 1, 2016

It's pylint.rc from my project.
If there's no comma after duplicate-code and there's comment after line with duplicate-code, this check is not disabled.

@PCManticore
Copy link
Contributor

This should be fixed now in the master. Unfortunately, I didn't backport it to 1.5.X, since I'm not sure yet what side effects this might introduce in a bug fix release. Let me know if it works for you.

@nvdv
Copy link
Author

nvdv commented Mar 23, 2016

It works for me. Thanks!

PCManticore added a commit that referenced this issue Jun 30, 2016
This fixes a problem we were having with comments inside values, which is fixed
in Python 3's configparser.
Close #828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants