[Backport maintenance/3.3.x] Consistency between is/is not and ==/!= when comparing types for unidiomatic-typecheck (#10170)
#10366
+39
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g types for ``unidiomatic-typecheck`` (pylint-dev#10170) (cherry picked from commit d396616)
jacobtylerwalls
changed the title
is/is not and ==/!= when comparing types for unidiomatic-typecheck (#10170)is/is not and ==/!= when comparing types for unidiomatic-typecheck (#10170)
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
May 4, 2025
zenlyj
approved these changes
May 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.3.x #10366 +/- ##
==================================================
Coverage 95.84% 95.84%
==================================================
Files 174 174
Lines 18995 18995
==================================================
Hits 18206 18206
Misses 789 789
🚀 New features to boost your workflow:
|
Pierre-Sassoulas
merged commit f9773de
into
pylint-dev:maintenance/3.3.x
27 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d396616)