Remove dead code #3257
Merged
Remove dead code #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just stumbled upon pylint-dev/astroid#251, which we should fix at some point. |
twmr
commented
Nov 18, 2019
This code is not needed, since get_ast with `data` != None is only needed for the --from-stdin feature, where get_ast is only called once. Therefore, a cache is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is not needed, since get_ast with
data!= None is onlyneeded for the --from-stdin feature, where get_ast is only called
once. Therefore, a cache is not needed.
Steps
doc/whatsnew/<current release.rst>.Description
Type of Changes
Related Issue