Skip to content

Add tests for ClassDef inference regression #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 7, 2021
Merged

Add tests for ClassDef inference regression #5037

merged 5 commits into from
Oct 7, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #5030
Closes #5036

Needs astroid update with pylint-dev/astroid#1181

@DanielNoord DanielNoord added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Sep 17, 2021
@DanielNoord DanielNoord added this to the 2.11.2 milestone Sep 17, 2021
@DanielNoord DanielNoord mentioned this pull request Sep 17, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas added Crash 💥 A bug that makes pylint crash Regression labels Sep 17, 2021
cdce8p
cdce8p reviewed Sep 17, 2021
View reviewed changes
cdce8p
cdce8p approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @DanielNoord!

@DanielNoord DanielNoord mentioned this pull request Sep 30, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas linked an issue Sep 30, 2021 that may be closed by this pull request
Exception in 2.11.0 #5096
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1316131318

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.179%
Totals Coverage Status
Change from base Build 1316093069: 0.0%
Covered Lines: 13537
Relevant Lines: 14528
💛 - Coveralls

@cdce8p cdce8p merged commit 5143e3a into pylint-dev:main Oct 7, 2021
@DanielNoord DanielNoord deleted the regression-5030 branch October 7, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable Regression
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Exception in 2.11.0 Crash 'NoneType' object is not iterable Fatal error with dataclass after 2.11
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @cdce8p