Get the msgids directly from the MessageIdStore

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

We don't need to create message definitions to get their msgids.

The level of indirection may suggest we need to refactor a
little here. Maybe we actually need message definition only
when we want to display the messages.

Follow-up to #5605

[coveralls]

Pull Request Test Coverage Report for Build 1631086682

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.0004%) to 93.717%

---

Totals
Change from base Build 1630989169:	-0.0004%
Covered Lines:	14334
Relevant Lines:	15295

---

💛 - Coveralls

[DanielNoord]

Is there a difference between the message definitions and the "active" message definitions?

[Pierre-Sassoulas]

I'll let you judge, here's the implementation of get_message_definitions 😄

    def get_message_definitions(self, msgid_or_symbol: str) -> List[MessageDefinition]:
        """Returns the Message definition for either a numeric or symbolic id."""
        return [
            self._messages_definitions[m]
            for m in self.message_id_store.get_active_msgids(msgid_or_symbol)
        ]

I think we discussed typing msgid at some point as msgid are string with a letter and 4 digits and decided against it. This might be a big refactor but using msgid everywhere instead of message definition might be a good idea. We could even transform symbol to msgid early on when it's user input.

[DanielNoord]

😄

The refactor should probably be left for a later point, but this is indeed a good fix!