Skip to content

Add distutils to deprecated modules #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2022
Merged

Add distutils to deprecated modules #5864

merged 4 commits into from
Mar 8, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Mar 7, 2022 •
edited
Loading

Type of Changes

Type
✓ ✨ New feature

Description

distutils was deprecated in Python 3.10. Adding it (and some other tiny methods and decorators that were missed) to the list of deprecations.

@coveralls
Copy link

coveralls commented Mar 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1948192654

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.005%
Totals Coverage Status
Change from base Build 1942297987: 0.0%
Covered Lines: 14944
Relevant Lines: 15897
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label Mar 7, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 7, 2022
Pierre-Sassoulas
Pierre-Sassoulas reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add the deprecated functions and disable the deprecation in our own code temporarily in 2.13 and then refactor the code later in 2.14 ? I'm not super confident in the change to the import checker right now.

@jacobtylerwalls
Copy link
Member Author

Sounds good to me, I agree there's no reason to rush in something under the wire that might be sensitive.

@jacobtylerwalls jacobtylerwalls mentioned this pull request Mar 7, 2022
Merged
@DanielNoord DanielNoord merged commit b1bb7f8 into pylint-dev:main Mar 8, 2022
@jacobtylerwalls jacobtylerwalls deleted the stdlib-310-deprecations branch March 8, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord