Skip to content

Revert "Fix crash when using enumerate with start and a class attribute (#7824)" #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

This reverts commit 86b8c64 which broke the test on the maintenance branch. Do you think this is fixable by cherry-picking something else first @clavedeluna ? Otherwise we can just wait for 2.16 to release the fix.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 26, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.7 milestone Nov 26, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Blocker πŸ™… Blocks the next release label Nov 26, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocker πŸ™… Blocks the next release label Nov 27, 2022
@clavedeluna
Copy link
Contributor

How did this happen? Is it because we merge without rebasing on to main first?

If so, I've personally always used the rebase strategy to prevent these situations. But since this repo doesn't have that practice then we get these situations.

I tried to reproduce this at no avail, with or without tox locally. Are you sure this failure wasnt a total fluke? The test runs on main here https://github.com/PyCQA/pylint/actions/workflows/tests.yaml?query=branch%3Amain do not indicate to me that there is any problem??

@Pierre-Sassoulas
Copy link
Member Author

How did this happen? Is it because we merge without rebasing on to main first?

The branch we're trying to merge on is the maintenance/2.15.x branch where we only cherry-pick the false positives and bugs. We might miss some refactor from main. If it isn't easy to know which commit also need to cherry picked we could wait for 2.16.0 to release this. If it would also bring new feature or warning and is impossible to separate then we must wait for 2.16.0.

Copy link
Member

@mbyrnepr2 mbyrnepr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Ok I can see the tests pass on the maintenance branch. Not 100% sure why they failed on the maintenance branch previously but we can always handle it a little bit later & get it merged.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 43109b6 into pylint-dev:maintenance/2.15.x Nov 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the revert-or-fix-7824-backport branch November 29, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants