-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support cyclic-import
message with --jobs
#8807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cyclic-import
message with --jobs
#8807
Conversation
cc2e556
to
61f551f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8807 +/- ##
==========================================
+ Coverage 95.87% 95.89% +0.01%
==========================================
Files 173 173
Lines 18503 18510 +7
==========================================
+ Hits 17740 17750 +10
+ Misses 763 760 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't understand why we cover the reduce without covering the get_map_data.. Should we pragma: no cover
it ?
I verified that the line is being hit, but it's hit during parallel processing, so there could be a bug in codecov. Let's not add a pragma for something that's a bug in codecov. |
The [skip ci] in the terminal commit prevent the CI from running properly. |
I did it on purpose to avoid wasting resources on linting a commit that removed lines from an RST file. I'll just override :-) |
Also, GitHub was not showing additional commits this morning, I opened a bug report with them and they just said "it happens sometimes" and didn't show it on githubstatus or anything. |
Also, the primer was failing on the first commit because the project cache was missing. It's possible that without frequent enough commits on main, the PRs will always fail because the needed cache gets evicted? |
I was wondering about the primer too. Funny that we would have an unusual drop in commit frequency and hitting never seen bugs π (I blame the high temperatures, and the attention astroid is getting lately). |
Type of Changes
Description
Closes #4171