Skip to content

Old version of the notebook GLM-Out-Of-Sample Predictions is currently shown #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juanitorduz opened this issue Nov 9, 2022 · 4 comments

Comments

@juanitorduz
Copy link
Collaborator

juanitorduz commented Nov 9, 2022

Notebook title: GLM in PyMC3: Out-Of-Sample Predictions
Notebook url: https://www.pymc.io/projects/examples/en/latest/generalized_linear_models/GLM-out-of-sample-predictions.html

Issue description

I am the original author of the GLM in PyMC3: Out-Of-Sample Predictions notebook. @drbenvincent did a fantastic job improving it 🚀 ...but it seems the old (mine initial) version is in the master branch. I believe it was modified in #376 . It would be great to bring Ben's updated version back!

Expected output

Lates corrected version which was available before.

Proposed solution

Maybe revert #376 ? or simply fix this notebook? My concern is that this could have happened to other notebooks ¯\(ツ)

@drbenvincent
Copy link
Contributor

Thanks for spotting this!

@twiecki
Copy link
Member

twiecki commented Dec 7, 2022

I think we should remove the NB as it's using the glm submodule.

@juanitorduz
Copy link
Collaborator Author

I think we should remove the NB as it's using the glm submodule.

@drbenvincent did a whole re-write of this notebook, it was great! the problem is that in the PR referenced abve for some reason the new version was replaced by the old one. See the notebook diff in #376 ;)

@drbenvincent
Copy link
Contributor

So I guess I need to fix this and bring the updated notebook back to life.

Time wise, could get to that summer point in the festive season when taking a break from my family. If there's urgency then happy if someone else wants to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants