-
-
Notifications
You must be signed in to change notification settings - Fork 269
Remove find_MAP demonstration in the getting started tutorial #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi, thanks for the PR. You should let us know what is your goal with this PR so we can review accordingly. We are updating all the notebooks progressively from their current state. The contributing guide explains all the situation and contributing process much better. |
Hi @OriolAbril my goal here was to remove find_MAP demonstration as mentioned in the issue #31, I hope that would be useful. I think, it would be better to close this issue and send in a similar pull request for v4? |
None of the issues labeled All contributions big or small are welcome which is why we need to know whet you aim so we don't ask you more than what you are comfortable working with. |
Okay, that sounds valid. I was thinking maybe to take this up as a task for my GSOD proposal. Can I contact you somewhere to discuss about this? |
We can discuss over at https://discourse.pymc.io/ you can open a topic there to discuss this. I regularly check the new topics and should see if but you can also tag me (same @OriolAbril tag as here) to be extra sure. |
Can this be closed? |
hey @Aut0R3V thanks for the contribution! are you still interested in working on this? there still are a lot of things missing/outdated like installation instructions/sampling methods etc, we'd all be happy to help you. If not, I think we should close it after another 14 days of inactivity? on that note, I can take this up, this would probably be an important notebook for the documentation point of view as well as It gets a lot of views, so it might be best to update it before a docs rebuild |
Closing due to inactivity |
Description
Addresses issue #31