Skip to content

Remove find_MAP demonstration in the getting started tutorial #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Aut0R3V
Copy link

@Aut0R3V Aut0R3V commented Apr 21, 2021

Description

Addresses issue #31

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

Hi, thanks for the PR. You should let us know what is your goal with this PR so we can review accordingly. We are updating all the notebooks progressively from their current state. The contributing guide explains all the situation and contributing process much better.

@Aut0R3V
Copy link
Author

Aut0R3V commented Apr 21, 2021

Hi @OriolAbril my goal here was to remove find_MAP demonstration as mentioned in the issue #31, I hope that would be useful. I think, it would be better to close this issue and send in a similar pull request for v4?
Thanks!

@OriolAbril
Copy link
Member

None of the issues labeled tracker_id will be closed anytime soon. Fixing things in these issues will have an effect in that they will change position in the notebook state tracker. Right now, the getting started notebook is heavily outdated so it's in the "To Do" column, depending on the extent of the fixes it can be still kept in "To Do" or move to another column (not yet v4 though). The issue lists some specifics to work on, but it is nor exhaustive in all the things that need to be updated nor it aims to be. Going over this wiki page for example can give you more ideas on specific things to update.

All contributions big or small are welcome which is why we need to know whet you aim so we don't ask you more than what you are comfortable working with.

@Aut0R3V
Copy link
Author

Aut0R3V commented Apr 22, 2021

Okay, that sounds valid. I was thinking maybe to take this up as a task for my GSOD proposal. Can I contact you somewhere to discuss about this?
Thanks!

@OriolAbril
Copy link
Member

OriolAbril commented Apr 22, 2021

We can discuss over at https://discourse.pymc.io/ you can open a topic there to discuss this. I regularly check the new topics and should see if but you can also tag me (same @OriolAbril tag as here) to be extra sure.

@fonnesbeck
Copy link
Member

Can this be closed?

@mjhajharia
Copy link
Member

mjhajharia commented Aug 18, 2021

Can this be closed?

hey @Aut0R3V thanks for the contribution! are you still interested in working on this? there still are a lot of things missing/outdated like installation instructions/sampling methods etc, we'd all be happy to help you. If not, I think we should close it after another 14 days of inactivity? on that note, I can take this up, this would probably be an important notebook for the documentation point of view as well as It gets a lot of views, so it might be best to update it before a docs rebuild

@fonnesbeck
Copy link
Member

Closing due to inactivity

@fonnesbeck fonnesbeck closed this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants